Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gguf.md: naming convention synced to llama.cpp #896

Merged
merged 1 commit into from
Jul 22, 2024
Merged

gguf.md: naming convention synced to llama.cpp #896

merged 1 commit into from
Jul 22, 2024

Conversation

mofosyne
Copy link
Contributor

ggerganov/llama.cpp#7499 was merged in, thus this PR is to sync to this new form

<BaseName><SizeLabel><FineTune><Version><Encoding><Type><Shard>.gguf

I also updated the validation regexp you can use

^(?<BaseName>[A-Za-z0-9\s]*(?:(?:-(?:(?:[A-Za-z\s][A-Za-z0-9\s]*)|(?:[0-9\s]*)))*))-(?:(?P<SizeLabel>(?:\d+x)?(?:\d+\.)?\d+[A-Za-z](?:-[A-Za-z]+(\d+\.)?\d+[A-Za-z]+)?)(?:-(?P<FineTune>[A-Za-z0-9\s-]+))?)?-(?:(?P<Version>v\d+(?:\.\d+)*))(?:-(?<Encoding>(?!LoRA|vocab)[\w_]+))?(?:-(?<Type>LoRA|vocab))?(?:-(?P<Shard>\d{5}-of-\d{5}))?\.gguf$

You can check how it works in https://regex101.com/r/7DgTVN/1

@mofosyne
gguf.md: naming convention synced to llama.cpp
eb092eb 
It is now updated to this form

`<BaseName><SizeLabel><FineTune><Version><Encoding><Type><Shard>.gguf`
@mofosyne mofosyne mentioned this pull request Jul 21, 2024
Closed
@mofosyne
Copy link
Contributor Author

for vocab files... does a size label even make sense?

@ggerganov ggerganov merged commit f18a111 into ggerganov:master Jul 22, 2024
4 checks passed
@mofosyne mofosyne deleted the namingconvention branch July 22, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mofosyne @ggerganov